feat(workspace): Storybook tokens for rehearsal components - #897
feat(workspace): Storybook tokens for rehearsal components#897seonghobae wants to merge 48 commits into
Conversation
…onents Cite Figma 19-239 and docs/design-system/component-contract.md. Extract OverlapWarningList for Section Roadmap and Ranges. Cover ConfidenceBadge, PracticeProgress, RehearsalCallout, RoleSwitcher, WorkspaceStates, and SectionRoadmap.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
📝 WalkthroughWalkthroughWorkspace 디자인 토큰과 컴포넌트 계약을 갱신했습니다. ChangesWorkspace 컴포넌트와 디자인 토큰
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: 🔵 Low · up to The change is mergeable with owner follow-up to unify the documented Figma component name, node mapping, and verification date so design evidence remains unambiguous; no runtime or security risk is identified. Sequence Diagram(s)sequenceDiagram
participant Ranges
participant SectionRoadmap
participant OverlapWarningList
Ranges->>OverlapWarningList: overlapWarnings와 surface="light" 전달
SectionRoadmap->>OverlapWarningList: overlapWarnings 전달
OverlapWarningList-->>Ranges: 표면별 경고 목록 렌더링
OverlapWarningList-->>SectionRoadmap: 기본 dark 경고 목록 렌더링
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 14 files. (4 skipped: 4 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headdfea7b7ae6df7e0c480da823561b279e3cb332fc. -
Head SHA:
dfea7b7ae6df7e0c480da823561b279e3cb332fc -
Workflow run: 32013942820
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (19 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (19 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs: component-contract.md"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs: component-contract.md"]
R2 --> V2["docs review"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage evidence job did not run or did not publish coverage evidence. Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (23 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (23 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs: component-contract.md"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs: component-contract.md"]
R2 --> V2["docs review"]
|
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head6a6c085d9b26a2275d047cc40eb050725384eeca. -
Head SHA:
6a6c085d9b26a2275d047cc40eb050725384eeca -
Workflow run: 32085816271
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (20 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (20 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs: component-contract.md"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs: component-contract.md"]
R2 --> V2["docs review"]
|
@opencode-agent review Please re-evaluate exact current head |
|
@opencode-agent review Exact-current-head review request for |
1 participant
Product outcome
Rehearsal workspace components have executable Storybook coverage and shared design tokens so design review exercises the same states a band sees. The shared overlap-warning component selects explicit dark/light surface contracts so clash guidance remains readable in both the dark rehearsal workspace and white Ranges cards.
Exact current identity
develop@749511c3ad4000090048718f685c6bee6b3d2c25.d43682078eb45383399550b9b64ce916047cb523.163c2e7b1ef26c037d9625054843ace2573baf55and027bd34734d8f24075e55c847ace7aa81a4a89fdand their checks are historical only.Current exact scope
ConfidenceBadge,PracticeProgress,RehearsalCallout,RoleSwitcher,WorkspaceStates,SectionRoadmap, andOverlapWarningList.OverlapWarningListis the shared clash list for Section Roadmap and Ranges; dark is the backward-compatible default and Ranges explicitly selects the light surface.docs/doctoring/overlap-warning-surface-contrast.mdrecords the WCAG 2.2 contrast decision with an APA 7 primary-standard reference and current live Figma node provenance.Workspace States,Pattern Backlog, andPR Review Rulesgovernance sections that were accidentally dropped have been restored.Fresh Figma + Storybook design authority — 2026-08-28
Configured Figma file: https://www.figma.com/design/zthWmqfNKUgJBECvv002Qk
The live file was freshly read and repaired against this PR's executable Storybook/runtime contract. It now exposes page
45:86(31 Component Contract Catalog) in addition to the cover. The restored authority includes:BandScope Workspace Semanticsvariables derived from the exact runtime token values;ConfidenceBadgecomponent set254:72with sixLevel=Low|Medium|High × Size=Compact|Defaultvariants, matching Storybook's complete matrix and 22/26 px runtime height tokens;OverlapWarningItemcomponent set254:81withSurface=DarkandSurface=Lightvariants;254:82using instances of that same warning component in the dark rehearsal workspace (254:85) and white Ranges card (254:96), plus the intentional no-nodeNoClashesstate (254:107);rgb(251 113 133 / 0.08)/rgb(253 164 175 / 0.2)/#FFE4E6, light#FFF1F2/#FECDD3/#9F1239.Post-write screenshot inspection caught an overlapping component-master presentation defect; the Figma catalog was immediately repaired to render reviewable instance matrices while retaining the reusable component sets as masters. A second screenshot verifies the confidence matrix, both warning surfaces, and empty state without clipping or overlap.
Historical nodes such as
19:239remain traceability only. Current design-review evidence is the page and component nodes above; Storybook remains the executable accessibility/interaction boundary and runtime CSS remains token authority.Current evidence boundary
Exact current head
d43682078eb45383399550b9b64ce916047cb523is the only code/check evidence for this PR. Predecessor success is not transferred and this PR is not merge-authorized. Current review threads are resolved/outdated; submitted reviews are advisory/model commentary only, with no qualifying independent non-author exact-head approval.Dependency / merge gate
developshipped truth. This branch inherits that JavaScript baseline and does not duplicate or suppress it.